Accepting Code Reviews from Slack
Last updated
Was this helpful?
Last updated
Was this helpful?
Most code reviews are available to be claimed through the PullRequest Reviewers Slack workspace. Once you've been on-boarded as a reviewer, you'll receive an invitation to join and have access to Slack channels where available code reviews matching your approved skills are posted.
Examples:
#nodejs-reviews
#php-reviews
#ruby-reviews
#ios-reviews
... and so on.
You'll be granted access to channels based on skills entered during PullRequest signup.
NOTE: If it appears you may be missing from some channels you should be added to, or if your skills change over time (ie - you've recently spent months becoming an Elixir wizard), please email reviewers@pullrequest.com or ping a PullRequest team member in Slack and we'll update accordingly.
Code reviews will be posted their respective channels as they become available.
Example:
This review will be posed to the #ruby-reviewers Slack channel.
The components of the new review messages are:
Reviewers needed - The number of reviewers who are eligible to claim the review. This number will update in real-time as it's claimed by reviewers, so at any given point the number displayed will accurately reflect the number of positions available.
Listed languages / frameworks - These are a list of technologies (languages, frameworks and related platforms) associated with the code review's repository. It's important to note the listed technologies are not necessarily exhaustive (ie - If a client begins to adopt a new framework) and the items listed may not necessarily be part of that specific code change. If at any point you've accepted a review you're not comfortable completing feel free to email reviewers@pullrequest.com or ping a PullRequest team member in Slack.
Accept link - The link displayed will open the PullRequest reviewer platform where you'll be able to see more of the code review's details and accept the review.
Please note: clicking on the "accept" link in Slack will not assign the code review to you, the code review is assigned after it has been clicked to be accepted on the PullRequest platform.
As soon as a code review has been claimed by its max number of reviewers, the state of the message will change to the following:
If the code review becomes available again after it has reached the "claimed" state (ie - A reviewer is unassigned from it or an additional reviewer slot is added), a new message will be sent to the Slack channel.
After clicking on an available review in Slack, you'll be taken to the PullRequest Reviewer platform to review some more of the code review's details and accept the review.
If you're logged out of the PullRequest Platform on your browser you'll be asked at this point to log in. If you haven't already, make sure to enable two-factor authentication.
Clicking Accept will assign the code review to your account. Clicking Cancel will not cause your account to be ineligible to claim the review. You'll still be able to claim the review if "Cancel" was clicked accidentally.
As part of our commitment to provide a great experience for both our customers and reviewers, we ask our reviewers to address code reviews promptly after they've been claimed.
If 30 minutes pass after a review has been accepted and work has not started on the review, it will be unassigned from the reviewer and posted back to the reviewer network as an available review for others to claim.
If for whatever reason you're unable to complete a code review you've accepted (hey, things happen!) please email reviewers@pullrequest.com or ping a PullRequest team member in Slack.
We care for our reviewers and we're very happy to have them in our network. Please be courteous and kind to your fellow reviewers both in the PullRequest Reviewers Slack Workspace and on code reviews.
PullRequest does not tolerate harassment of any kind. To report harassment, please email support@pullrequest.com immediately or ping a PullRequest team member.
